<webview>: Do not show blocked_by_client error page for guest.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 3635 matching lines @@
   params.url = error.unreachableURL;
   params.showing_repost_interstitial = show_repost_interstitial;
   Send(new ViewHostMsg_DidFailProvisionalLoadWithError(
       routing_id_, params));
 
   // Don't display an error page if this is simply a cancelled load.  Aside
   // from being dumb, WebCore doesn't expect it and it will cause a crash.
   if (error.reason == net::ERR_ABORTED)
     return;
 
+  // Don't display "client blocked" error page if browser has asked us not to.
+  if (error.reason == net::ERR_BLOCKED_BY_CLIENT &&
+      renderer_preferences_.disable_client_blocked_error_page) {
+    return;
+  }
+
   if (RenderThreadImpl::current()->layout_test_mode())
     return;
 
   // Make sure we never show errors in view source mode.
   frame->enableViewSourceMode(false);
 
   DocumentState* document_state = DocumentState::FromDataSource(ds);
   NavigationState* navigation_state = document_state->navigation_state();
 
   // If this is a failed back/forward/reload navigation, then we need to do a
   // 'replace' load.  This is necessary to avoid messing up session history.

[Charlie Reis, 2013/09/03 23:14:31]

I'm having trouble understanding why you want to diverge from the normal
didFailProvisionalLoad behavior.  This comment in particular makes me concerned
that the session history will be affected.

Is it just the "blocked by an extension" wording that's a problem?  Maybe
there's a way to change the wording?  Or is there a reason you can't show an
error page?

[Fady Samuel, 2013/09/13 20:12:22]

There is a desire to give <webview> developers the ability to block navigations.
Currently, only the WebRequest API can do that for <webview> (unless we
introduce an alternative mechanism).

[Charlie Reis, 2013/09/13 21:44:56]

I suppose this comment mainly applies to the LoadNavigationErrorPage call below,
so this change is making it behave more like the ERR_ABORTED case.

   // Otherwise, we do a normal load, which simulates a 'go' navigation as far
   // as session history is concerned.
   //
   // AUTO_SUBFRAME loads should always be treated as loads that do not advance
   // the page id.
   //
   bool replace =
       navigation_state->pending_page_id() != -1 ||
       PageTransitionCoreTypeIs(navigation_state->transition_type(),
                                PAGE_TRANSITION_AUTO_SUBFRAME);
@@ skipping 2845 matching lines @@
   for (size_t i = 0; i < icon_urls.size(); i++) {
     WebURL url = icon_urls[i].iconURL();
     if (!url.isEmpty())
       urls.push_back(FaviconURL(url,
                                 ToFaviconType(icon_urls[i].iconType())));
   }
   SendUpdateFaviconURL(urls);
 }
 
 }  // namespace content