Issue 23855004: Refactoring LineBreaker and RenderTextInfo out of RenderBlock.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23855004: Refactoring LineBreaker and RenderTextInfo out of RenderBlock.h (Closed)

Created:
7 years, 3 months ago by leviw_travelin_and_unemployed

Modified:
7 years, 3 months ago

Reviewers:
eseidel, eae, ojan

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Refactoring LineBreaker and RenderTextInfo out of RenderBlock.h LineBreaker and RenderTextInfo are defined in RenderBlock.h, but only used in RenderBlockLineLayout.cpp. Moving them there (LineBreaker needs to be a friend class of RenderBlock) in the first step in the process of refactoring LineBreaker::NextSegmentBreak into more manageable chunks. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157402

Patch Set 1 #

Patch Set 2 : Fixing silly mistake. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -46 lines)			Patch
	M	Source/core/rendering/RenderBlock.h	View		3 chunks	+2 lines, -38 lines	0 comments	Download
	M	Source/core/rendering/RenderBlockLineLayout.cpp	View	1	7 chunks	+45 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/23855004/4001

7 years, 3 months ago (2013-09-07 00:19:51 UTC) #3

Message was sent while issue was closed.

Change committed as 157402

Expand Messages | Collapse Messages