Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 23851034: GetDeviceCaps doesn't need to be scaled. (Closed)

Created:
7 years, 3 months ago by girard
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

GetDeviceCaps doesn't need to be scaled. At scale factors above 125%, we are over-scaling up the dpi calculation. BUG=292607 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223478

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/browser/metrics/metrics_log.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
girard
The code that I landed in https://src.chromium.org/viewvc/chrome?view=rev&revision=198574 is broken - I had tested it at ...
7 years, 3 months ago (2013-09-16 13:31:18 UTC) #1
sky
LGTM
7 years, 3 months ago (2013-09-16 17:22:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/girard@chromium.org/23851034/1
7 years, 3 months ago (2013-09-16 17:35:55 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 23:59:21 UTC) #4
Message was sent while issue was closed.
Change committed as 223478

Powered by Google App Engine
This is Rietveld 408576698