ui/views/accessibility/native_view_accessibility_win.cc - Issue 23851012: Fix crash when calling get_accChild on empty WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/accessibility/native_view_accessibility_win.cc

Issue 23851012: Fix crash when calling get_accChild on empty WebView. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/accessibility/native_view_accessibility_win.cc

diff --git a/ui/views/accessibility/native_view_accessibility_win.cc b/ui/views/accessibility/native_view_accessibility_win.cc

index 5a853ab69b950b216ac9d134ea4d3d4173100c42..55bf1985a82e7a4d0540b469315fc90ff12ac9cf 100644

--- a/ui/views/accessibility/native_view_accessibility_win.cc

+++ b/ui/views/accessibility/native_view_accessibility_win.cc

@@ -106,7 +106,7 @@ IAccessible* AccessibleWebViewRegistry::GetAccessibleFromWebView(

for (std::set<View*>::iterator iter = web_views_.begin();

iter != web_views_.end(); ++iter) {

View* web_view = *iter;

- if (!top_view->Contains(web_view))

+ if (top_view == web_view || !top_view->Contains(web_view))

continue;

IAccessible* accessible = AccessibleObjectFromChildId(web_view, child_id);

if (accessible) {

« no previous file with comments | « no previous file | ui/views/accessibility/native_view_accessibility_win_unittest.cc » ('j') | no next file with comments »