Issue 23851012: Fix crash when calling get_accChild on empty WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23851012: Fix crash when calling get_accChild on empty WebView. (Closed)

Created:
7 years, 3 months ago by dmazzoni

Modified:
7 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, laforge

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix crash when calling get_accChild on empty WebView. We were getting an infinite loop if the WebView had no WebContents. Includes a regression test that reproduces the crash if the fix isn't included. BUG=287828 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222076

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -1 line)			Patch
	M	ui/views/accessibility/native_view_accessibility_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	ui/views/accessibility/native_view_accessibility_win_unittest.cc	View		2 chunks	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/23851012/1

7 years, 3 months ago (2013-09-09 16:32:10 UTC) #3

Message was sent while issue was closed.

Change committed as 222076

Expand Messages | Collapse Messages