Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2385083002: Make ProfileSyncService a client of memory coordinator (Closed)

Created:
4 years, 2 months ago by hajimehoshi
Modified:
4 years, 2 months ago
Reviewers:
maxbogue, chrisha, bashi
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ProfileSyncService a client of memory coordinator When the memory coordinator is enabled, ProfileSyncService becomes a client of the memory coordinator instead of installing MemoryPressureListener. In the implmentation of this CL, both MemoryPressureListener and MemoryCoordinatorClient are installed regardless of the flag, but as default MemoryCoordinator is not enabled and when MemoryCoordinator is enabled by a flag, it is planed to suppress MemoryPressureMonitor features. In addition, the current implementation of OnMemoryPressure just increments a UMA count. OnStateMemoryChange just follows this and doesn't do any memory reduction. Design Doc: https://docs.google.com/document/d/1a69mMr7jI7qK0OfKNlrZ350xiXizVMCCe8orGX7K8Uo/edit?ts=57d7968b# BUG=639700

Patch Set 1 #

Patch Set 2 : (rebasing) #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M components/browser_sync/profile_sync_service.h View 3 chunks +8 lines, -1 line 0 comments Download
M components/browser_sync/profile_sync_service.cc View 1 4 chunks +28 lines, -2 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 13 (10 generated)
hajimehoshi
PTAL
4 years, 2 months ago (2016-10-03 09:19:18 UTC) #7
bashi
https://codereview.chromium.org/2385083002/diff/20001/components/browser_sync/profile_sync_service.cc File components/browser_sync/profile_sync_service.cc (right): https://codereview.chromium.org/2385083002/diff/20001/components/browser_sync/profile_sync_service.cc#newcode2476 components/browser_sync/profile_sync_service.cc:2476: sync_prefs_.GetMemoryPressureWarningCount() + 1); Do we use the warning count ...
4 years, 2 months ago (2016-10-03 23:26:54 UTC) #12
hajimehoshi
4 years, 2 months ago (2016-10-04 05:36:23 UTC) #13
As we discussed offline, let's just remove the UMA. Let me close this.

Powered by Google App Engine
This is Rietveld 408576698