Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 23849003: Add support for java side bookmark model observers. (Closed)

Created:
7 years, 3 months ago by Ted C
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add support for java side bookmark model observers. Allows java bookmark UIs to update to changes to the underlying model. BUG=247381 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221869

Patch Set 1 #

Total comments: 8

Patch Set 2 : Updated javadocs for consistency #

Patch Set 3 : Address newt@ comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -18 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java View 1 5 chunks +139 lines, -9 lines 0 comments Download
M chrome/browser/android/bookmarks_bridge.h View 2 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/android/bookmarks_bridge.cc View 1 2 3 chunks +111 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ted C
PTAL
7 years, 3 months ago (2013-09-06 21:43:33 UTC) #1
David Trainor- moved to gerrit
lgtm
7 years, 3 months ago (2013-09-06 21:55:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/23849003/5001
7 years, 3 months ago (2013-09-06 22:01:19 UTC) #3
newt (away)
lgtm https://chromiumcodereview.appspot.com/23849003/diff/1/chrome/browser/android/bookmarks_bridge.cc File chrome/browser/android/bookmarks_bridge.cc (right): https://chromiumcodereview.appspot.com/23849003/diff/1/chrome/browser/android/bookmarks_bridge.cc#newcode113 chrome/browser/android/bookmarks_bridge.cc:113: int64 parent_id = -1; maybe: int64 parent_id = ...
7 years, 3 months ago (2013-09-06 22:06:32 UTC) #4
Ted C
https://chromiumcodereview.appspot.com/23849003/diff/1/chrome/browser/android/bookmarks_bridge.cc File chrome/browser/android/bookmarks_bridge.cc (right): https://chromiumcodereview.appspot.com/23849003/diff/1/chrome/browser/android/bookmarks_bridge.cc#newcode113 chrome/browser/android/bookmarks_bridge.cc:113: int64 parent_id = -1; On 2013/09/06 22:06:33, newt wrote: ...
7 years, 3 months ago (2013-09-06 22:14:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/23849003/23001
7 years, 3 months ago (2013-09-06 22:18:19 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-07 03:05:58 UTC) #7
Message was sent while issue was closed.
Change committed as 221869

Powered by Google App Engine
This is Rietveld 408576698