Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 23848007: Fixing the bounds check in cancelCompositionIfSelectionIsInvalid. (Closed)

Created:
7 years, 3 months ago by aurimas (slooooooooow)
Modified:
7 years, 3 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fixing the bounds check in cancelCompositionIfSelectionIsInvalid. Selection move to the start or the end of the composition node should not cancel the composition. BUG=283616 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157345

Patch Set 1 #

Patch Set 2 : Adding a test #

Total comments: 2

Patch Set 3 : Adding two more test cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -2 lines) Patch
M Source/core/editing/InputMethodController.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 2 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
aurimas (slooooooooow)
Hey Yoshifumi, Please take a look at this CL. Thanks, Aurimas
7 years, 3 months ago (2013-09-05 23:03:34 UTC) #1
aurimas (slooooooooow)
+tkent for the review as an OWNER
7 years, 3 months ago (2013-09-06 00:16:35 UTC) #2
yosin_UTC9
ACK for code change. We want to have two more test cases for edge cases. ...
7 years, 3 months ago (2013-09-06 01:17:55 UTC) #3
aurimas (slooooooooow)
Added the additional test cases. https://chromiumcodereview.appspot.com/23848007/diff/2001/Source/web/tests/WebViewTest.cpp File Source/web/tests/WebViewTest.cpp (right): https://chromiumcodereview.appspot.com/23848007/diff/2001/Source/web/tests/WebViewTest.cpp#newcode722 Source/web/tests/WebViewTest.cpp:722: webView->setEditableSelectionOffsets(2, 2); On 2013/09/06 ...
7 years, 3 months ago (2013-09-06 01:25:35 UTC) #4
yosin_UTC9
ACK
7 years, 3 months ago (2013-09-06 01:33:08 UTC) #5
aurimas (slooooooooow)
tkent: could you take a look at this CL too?
7 years, 3 months ago (2013-09-06 01:36:21 UTC) #6
tkent
lgtm yosin@, please use the term 'lgtm', instead of uncommon 'ACK.'
7 years, 3 months ago (2013-09-06 02:06:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/23848007/10001
7 years, 3 months ago (2013-09-06 02:09:40 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=4420
7 years, 3 months ago (2013-09-06 03:59:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/23848007/10001
7 years, 3 months ago (2013-09-06 04:14:39 UTC) #10
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 04:57:21 UTC) #11
Message was sent while issue was closed.
Change committed as 157345

Powered by Google App Engine
This is Rietveld 408576698