Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 23847005: Fix order of UMA sampling when handling errors on initial policy fetch. (Closed)

Created:
7 years, 3 months ago by Joao da Silva
Modified:
7 years, 3 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Fix order of UMA sampling when handling errors on initial policy fetch. BUG=271321 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Joao da Silva
Please review, thanks!
7 years, 3 months ago (2013-09-09 07:53:23 UTC) #1
Mattias Nissler (ping if slow)
Whoops, good catch. Can you please update the commit message to reference the right BUG?
7 years, 3 months ago (2013-09-09 07:54:37 UTC) #2
Mattias Nissler (ping if slow)
Oh, and LGTM.
7 years, 3 months ago (2013-09-09 07:54:45 UTC) #3
Joao da Silva
Added BUG, thanks for reviewing!
7 years, 3 months ago (2013-09-09 08:23:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/23847005/1
7 years, 3 months ago (2013-09-09 08:24:02 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 10:40:39 UTC) #6
Message was sent while issue was closed.
Change committed as 221999

Powered by Google App Engine
This is Rietveld 408576698