Issue 23843005: Report accelerated surface vsync time info to browser compositor.

Issue 23843005: Report accelerated surface vsync time info to browser compositor. (Closed)

Created:
7 years, 3 months ago by jbauman

Modified:
7 years, 3 months ago

Reviewers:
jschuh, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, apatrick_chromium, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Report accelerated surface vsync time info to browser compositor. The code was sending it directly to the RenderWidgetHostImpl, which doesn't work if the surface is connected to the browser compositor. It needs to be sent to the GPU process, which can route it correctly. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223388

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -10 lines)			Patch
M	content/browser/gpu/gpu_process_host.cc	View	1	5 chunks	+18 lines, -9 lines	0 comments	Download
M	content/common/gpu/gpu_messages.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/common/gpu/image_transport_surface_win.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

piman

https://codereview.chromium.org/23843005/diff/1/content/common/gpu/gpu_messages.h File content/common/gpu/gpu_messages.h (right): https://codereview.chromium.org/23843005/diff/1/content/common/gpu/gpu_messages.h#newcode87 content/common/gpu/gpu_messages.h:87: IPC_STRUCT_MEMBER(base::TimeTicks, vsync_timebase) nit: put inside a #if defined(OS_WIN), since ...

7 years, 3 months ago (2013-09-14 02:29:07 UTC) #2

piman

On 2013/09/14 02:29:07, piman wrote: > https://codereview.chromium.org/23843005/diff/1/content/common/gpu/gpu_messages.h > File content/common/gpu/gpu_messages.h (right): > > https://codereview.chromium.org/23843005/diff/1/content/common/gpu/gpu_messages.h#newcode87 > ...

7 years, 3 months ago (2013-09-14 02:29:29 UTC) #3

jbauman

Also adding jschuh@ to review the (trivial) gpu_messages.h change.

7 years, 3 months ago (2013-09-14 02:37:04 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/23843005/7001

7 years, 3 months ago (2013-09-16 18:03:58 UTC) #6

Message was sent while issue was closed.

Change committed as 223388

Expand Messages | Collapse Messages