Disable WebViewTest.ClearData on WinXP.

Disable WebViewTest.ClearData on WinXP.

NOTRY=true
BUG=282674
Test=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220692

[Lambros, 2013-08-30 23:07:35]

lgtm with nit. Thanks for doing this for me!

https://codereview.chromium.org/23840002/diff/1/chrome/browser/apps/web_view_...
File chrome/browser/apps/web_view_browsertest.cc (right):

https://codereview.chromium.org/23840002/diff/1/chrome/browser/apps/web_view_...
chrome/browser/apps/web_view_browsertest.cc:1545: if (base::win::GetVersion() <=
base::win::VERSION_XP)
nit: #include "base/win/windows_version.h" for GetVersion().

[lazyboy, 2013-08-30 23:15:31]

https://codereview.chromium.org/23840002/diff/1/chrome/browser/apps/web_view_...
File chrome/browser/apps/web_view_browsertest.cc (right):

https://codereview.chromium.org/23840002/diff/1/chrome/browser/apps/web_view_...
chrome/browser/apps/web_view_browsertest.cc:1545: if (base::win::GetVersion() <=
base::win::VERSION_XP)
On 2013/08/30 23:07:35, Lambros wrote:
> nit: #include "base/win/windows_version.h" for GetVersion().

Seems like it is already included.

[Lambros, 2013-08-30 23:19:56]

https://codereview.chromium.org/23840002/diff/1/chrome/browser/apps/web_view_...
File chrome/browser/apps/web_view_browsertest.cc (right):

https://codereview.chromium.org/23840002/diff/1/chrome/browser/apps/web_view_...
chrome/browser/apps/web_view_browsertest.cc:1545: if (base::win::GetVersion() <=
base::win::VERSION_XP)
On 2013/08/30 23:15:31, lazyboy wrote:
> On 2013/08/30 23:07:35, Lambros wrote:
> > nit: #include "base/win/windows_version.h" for GetVersion().
> 
> Seems like it is already included.

I don't see it in this file in this CL. Transitive #inclusion is generally
frowned upon, see:
https://code.google.com/p/chromium/wiki/IncludeWhatYouUse

[Lambros, 2013-08-30 23:21:35]

On 2013/08/30 23:19:56, Lambros wrote:
>
https://codereview.chromium.org/23840002/diff/1/chrome/browser/apps/web_view_...
> File chrome/browser/apps/web_view_browsertest.cc (right):
> 
>
https://codereview.chromium.org/23840002/diff/1/chrome/browser/apps/web_view_...
> chrome/browser/apps/web_view_browsertest.cc:1545: if (base::win::GetVersion()
<=
> base::win::VERSION_XP)
> On 2013/08/30 23:15:31, lazyboy wrote:
> > On 2013/08/30 23:07:35, Lambros wrote:
> > > nit: #include "base/win/windows_version.h" for GetVersion().
> > 
> > Seems like it is already included.
> 
> I don't see it in this file in this CL. Transitive #inclusion is generally
> frowned upon, see:
> https://code.google.com/p/chromium/wiki/IncludeWhatYouUse

Oops, sorry! :) I missed the OS-specific section below the main #includes.

[lazyboy, 2013-08-30 23:21:49]

https://codereview.chromium.org/23840002/diff/1/chrome/browser/apps/web_view_...
File chrome/browser/apps/web_view_browsertest.cc (right):

https://codereview.chromium.org/23840002/diff/1/chrome/browser/apps/web_view_...
chrome/browser/apps/web_view_browsertest.cc:32: #include
"base/win/windows_version.h"
Here.

https://codereview.chromium.org/23840002/diff/1/chrome/browser/apps/web_view_...
chrome/browser/apps/web_view_browsertest.cc:1545: if (base::win::GetVersion() <=
base::win::VERSION_XP)
On 2013/08/30 23:19:56, Lambros wrote:
> On 2013/08/30 23:15:31, lazyboy wrote:
> > On 2013/08/30 23:07:35, Lambros wrote:
> > > nit: #include "base/win/windows_version.h" for GetVersion().
> > 
> > Seems like it is already included.
> 
> I don't see it in this file in this CL. Transitive #inclusion is generally
> frowned upon, see:
> https://code.google.com/p/chromium/wiki/IncludeWhatYouUse

^^^

[commit-bot: I haz the power, 2013-08-30 23:27:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lazyboy@chromium.org/23840002/1

[commit-bot: I haz the power, 2013-08-30 23:27:33]

Change committed as 220692