Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 23839003: cc: Make DelayBasedTimeSource robust to large deltas (Closed)

Created:
7 years, 3 months ago by enne (OOO)
Modified:
7 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org, brianderson
Visibility:
Public.

Description

cc: Make DelayBasedTimeSource robust to large deltas Trying to calculate elapsed intervals is prone to overflow errors. Just use modular arithmetic to figure out the closest next tick time to now. R=danakj@chromium.org BUG=282672 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220794

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -13 lines) Patch
M cc/scheduler/delay_based_time_source.cc View 1 chunk +14 lines, -13 lines 0 comments Download
M cc/scheduler/delay_based_time_source_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
enne (OOO)
7 years, 3 months ago (2013-08-31 00:13:33 UTC) #1
danakj
LGTM and may I say yay for modular arithmetic.
7 years, 3 months ago (2013-08-31 15:13:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/23839003/1
7 years, 3 months ago (2013-08-31 15:14:09 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=164328
7 years, 3 months ago (2013-08-31 18:40:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/23839003/1
7 years, 3 months ago (2013-08-31 19:19:00 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=164336
7 years, 3 months ago (2013-08-31 22:36:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/23839003/1
7 years, 3 months ago (2013-08-31 23:12:49 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-02 05:05:51 UTC) #8
Message was sent while issue was closed.
Change committed as 220794

Powered by Google App Engine
This is Rietveld 408576698