Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 23838003: Add HTTP Peer to DownloadSources enumeration (Closed)

Created:
7 years, 3 months ago by zeuthen
Modified:
7 years, 3 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add HTTP Peer to DownloadSources enumeration This way the Installer.DownloadSourcesUsed metric conveys how often p2p is used and new metrics Installer.SuccessfulMBsDownloadedFromHttpPeer and Installer.TotalMBsDownloadedFromHttpPeer gives additional detail. BUG=chromium:284714 TEST=Validated the xml, pretty print succeeded. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221214

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated patch set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
zeuthen
Thanks for the review. The corresponding code change for the ChromeOS update_engine is here: https://chromium-review.googlesource.com/#/c/167913/
7 years, 3 months ago (2013-09-03 21:09:06 UTC) #1
Ilya Sherman
histograms.xml lgtm https://codereview.chromium.org/23838003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/23838003/diff/1/tools/metrics/histograms/histograms.xml#newcode25140 tools/metrics/histograms/histograms.xml:25140: + <int value="3" label="HTTP Server, HTTPS Server"/> ...
7 years, 3 months ago (2013-09-03 22:43:23 UTC) #2
zeuthen
On 2013/09/03 22:43:23, Ilya Sherman wrote: > nit: IMO "and" would be clearer than a ...
7 years, 3 months ago (2013-09-04 01:00:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeuthen@chromium.org/23838003/6001
7 years, 3 months ago (2013-09-04 01:14:39 UTC) #4
commit-bot: I haz the power
Change committed as 221214
7 years, 3 months ago (2013-09-04 17:17:10 UTC) #5
zeuthen
7 years, 3 months ago (2013-09-10 00:02:34 UTC) #6
Message was sent while issue was closed.
Ooops, sorry for the noise. Hit the wrong button.

Powered by Google App Engine
This is Rietveld 408576698