DevTools: Do not close devtools if there are dirty files in workspace

chrome/browser/ui/tabs/tab_strip_model.cc

Index: chrome/browser/ui/tabs/tab_strip_model.cc
diff --git a/chrome/browser/ui/tabs/tab_strip_model.cc b/chrome/browser/ui/tabs/tab_strip_model.cc
index 91042c7a0a60a40aaed18397615fa5422c8fd6fb..47d5cea0da3d866a418c540949636663c627367a 100644
--- a/chrome/browser/ui/tabs/tab_strip_model.cc
+++ b/chrome/browser/ui/tabs/tab_strip_model.cc
@@ -13,6 +13,7 @@
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/browser_shutdown.h"
 #include "chrome/browser/defaults.h"
+#include "chrome/browser/devtools/devtools_window.h"
 #include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/tab_contents/core_tab_helper.h"
@@ -1202,6 +1203,9 @@ bool TabStripModel::InternalCloseTabs(const std::vector<int>& indices,
     std::map<content::RenderProcessHost*, size_t> processes;
     for (size_t i = 0; i < indices.size(); ++i) {
       WebContents* closing_contents = GetWebContentsAtImpl(indices[i]);
+      if (DevToolsWindow::GetInstanceForInspectedRenderViewHost(

[sky, 2013/11/05 16:37:10]

If you are going to tie the two together I think it better done else where, and
not explicitly in the tabstrip.

[lushnikov, 2013/11/05 17:27:22]

We don't really tie anything here. This part of tab strip attempts to close
webcontents via a fast path, which is fully managed by content layer, and which
we would like to skip for those webcontents which have devtools opened.
 
We would like to keep all of this logic in the chrome layer without
touching content, and I didn't find any better place in chrome-layer  to skip
this behaviour. I would appreciate any suggestions regarding this case!

[lushnikov, 2013/11/06 17:01:41]

Removed explicit DevTools presence in tab_strip_model

+          closing_contents->GetRenderViewHost()))
+        continue;
       content::RenderProcessHost* process =
           closing_contents->GetRenderProcessHost();
       ++processes[process];