Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: chrome/browser/ui/tabs/tab_strip_model.cc

Issue 23835007: DevTools: Do not close devtools if there are dirty files in workspace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: improving TestDevToolsOnDevTools test Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tabs/tab_strip_model.cc
diff --git a/chrome/browser/ui/tabs/tab_strip_model.cc b/chrome/browser/ui/tabs/tab_strip_model.cc
index 980e549dc5000b261fab9063e0b250dde6004585..b01a12874086a7e39d028f48ed4a9abb9bf18685 100644
--- a/chrome/browser/ui/tabs/tab_strip_model.cc
+++ b/chrome/browser/ui/tabs/tab_strip_model.cc
@@ -13,6 +13,7 @@
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/browser_shutdown.h"
#include "chrome/browser/defaults.h"
+#include "chrome/browser/devtools/devtools_window.h"
#include "chrome/browser/extensions/tab_helper.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/tab_contents/core_tab_helper.h"
@@ -1101,6 +1102,9 @@ bool TabStripModel::InternalCloseTabs(const std::vector<int>& indices,
std::map<content::RenderProcessHost*, size_t> processes;
for (size_t i = 0; i < indices.size(); ++i) {
WebContents* closing_contents = GetWebContentsAtImpl(indices[i]);
+ if (DevToolsWindow::GetInstanceForInspectedRenderViewHost(
+ closing_contents->GetRenderViewHost()))
+ continue;
content::RenderProcessHost* process =
closing_contents->GetRenderProcessHost();
++processes[process];

Powered by Google App Engine
This is Rietveld 408576698