Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/browser/devtools/devtools_window.h

Issue 23835007: DevTools: Do not close devtools if there are dirty files in workspace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: improving TestDevToolsOnDevTools test Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_window.h
diff --git a/chrome/browser/devtools/devtools_window.h b/chrome/browser/devtools/devtools_window.h
index 0f1bdd696de7074aa03b448226e989fa78496906..f84f12ea721d7dddf034e037e4205ce9cb2875a7 100644
--- a/chrome/browser/devtools/devtools_window.h
+++ b/chrome/browser/devtools/devtools_window.h
@@ -130,6 +130,14 @@ class DevToolsWindow : private content::NotificationObserver,
void Show(const DevToolsToggleAction& action);
+ static bool HandleBeforeUnload(content::WebContents*, bool, bool*);
+ static bool InterceptPageBeforeUnload(content::WebContents*);
+ static bool ShouldCloseDevToolsBrowser(Browser*);
+ static bool NeedToFireBeforeUnload(content::WebContents* contents);
+ void InspectedPageCancelClose();
+
+ void SetDockSideForTest(DevToolsDockSide dock_side);
+
private:
friend class DevToolsControllerTest;
@@ -279,6 +287,7 @@ class DevToolsWindow : private content::NotificationObserver,
int width_;
int height_;
DevToolsDockSide dock_side_before_minimized_;
+ bool inspected_page_is_closing_;
scoped_ptr<DevToolsEmbedderMessageDispatcher> embedder_message_dispatcher_;
base::WeakPtrFactory<DevToolsWindow> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698