Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Issue 23835005: Remove dependency to file_system_operation_impl.h from chrome/ (Closed)

Created:
7 years, 3 months ago by kinuko
Modified:
7 years, 3 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, Lei Zhang, tzik+watch_chromium.org, Greg Billock, tommycli, darin-cc_chromium.org, oshima+watch_chromium.org, nhiroki+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove dependency to file_system_operation_impl.h outside from chrome/ Instead introducing a static FileSystemOperation::Create method. As a preparation for moving fileapi code from webkit/ to content/. (file_system_operation.h will be placed under content/public/browser/ while file_system_operation_impl.{h,cc} will be placed under content/browser/fileapi and will be hidden from chrome/) BUG=265770 TEST=existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -42 lines) Patch
M chrome/browser/chromeos/fileapi/file_system_backend.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_backend.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/local/sync_file_system_backend.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_system_operation.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation.h View 3 chunks +8 lines, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_operation_impl.h View 2 chunks +7 lines, -9 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation_impl.cc View 2 chunks +20 lines, -12 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/isolated_file_system_backend.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_backend.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/test_file_system_backend.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
Mechanical cleanup only. PTL c/b/chromeos/fileapi: satorux c/b/media_galleries/fileapi: vandebo everything else: nhiroki
7 years, 3 months ago (2013-09-06 10:33:16 UTC) #1
vandebo (ex-Chrome)
*media* LGTM
7 years, 3 months ago (2013-09-06 15:24:14 UTC) #2
satorux1
chrome/browser/chromeos/fileapi/file_system_backend.cc lgtm
7 years, 3 months ago (2013-09-09 01:12:17 UTC) #3
nhiroki
lgtm
7 years, 3 months ago (2013-09-09 01:16:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/23835005/1
7 years, 3 months ago (2013-09-09 02:16:11 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 06:15:26 UTC) #6
Message was sent while issue was closed.
Change committed as 221976

Powered by Google App Engine
This is Rietveld 408576698