Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 23828005: Add toHTMLDialogElement(), and use it. (Closed)

Created:
7 years, 3 months ago by tkent
Modified:
7 years, 3 months ago
Reviewers:
falken
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Add toHTMLDialogElement(), and use it. We'd like to avoid bare static_cast<>. BUG=none TEST=none; no behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157429

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDialogElement.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
7 years, 3 months ago (2013-09-09 03:13:28 UTC) #1
falken
lgtm
7 years, 3 months ago (2013-09-09 03:22:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/23828005/1
7 years, 3 months ago (2013-09-09 03:24:13 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 03:28:15 UTC) #4
Message was sent while issue was closed.
Change committed as 157429

Powered by Google App Engine
This is Rietveld 408576698