Clean up NativeTheme (particularly CommonTheme).

chrome/browser/ui/views/profiles/profile_chooser_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/profiles/profile_chooser_view.h"
 
 #include "base/macros.h"
 #include "base/metrics/user_metrics.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 202 matching lines @@
     SetImage(STATE_NORMAL, icon);
   }
 
   ~BackgroundColorHoverButton() override {}
 
  private:
   // views::LabelButton:
   void OnPaint(gfx::Canvas* canvas) override {
     if ((state() == STATE_PRESSED) ||
         (state() == STATE_HOVERED)) {
-      canvas->DrawColor(GetNativeTheme()->GetSystemColor(
-          ui::NativeTheme::kColorId_ButtonHoverBackgroundColor));

[Evan Stade, 2016/09/30 18:02:36]

one reason this was confusing is because it's not applied to anything that
actually looks like a button (these "buttons" look more like menu items), and
isn't used at all in normal controls (i.e. ui/views/controls).

[tdanderson, 2016/09/30 21:00:56]

Acknowledged. So should a TODO be then to replace the hard-coded use of 0xEAEAEA
here with a more consistently-used color choice?

[Evan Stade, 2016/09/30 22:18:59]

I did put a TODO in the cocoa version of this code. Probably what should
actually happen is this gets an ink drop highlight, and this color then goes
away.

+      canvas->DrawColor(SkColorSetRGB(0xEA, 0xEA, 0xEA));
     }
     LabelButton::OnPaint(canvas);
   }
 
   DISALLOW_COPY_AND_ASSIGN(BackgroundColorHoverButton);
 };
 
 // SizedContainer -------------------------------------------------
 
 // A simple container view that takes an explicit preferred size.
@@ skipping 2070 matching lines @@
       IncognitoModePrefs::GetAvailability(browser_->profile()->GetPrefs()) !=
           IncognitoModePrefs::DISABLED;
   return incognito_available && !browser_->profile()->IsGuestSession();
 }
 
 void ProfileChooserView::PostActionPerformed(
     ProfileMetrics::ProfileDesktopMenu action_performed) {
   ProfileMetrics::LogProfileDesktopMenu(action_performed, gaia_service_type_);
   gaia_service_type_ = signin::GAIA_SERVICE_TYPE_NONE;
 }