Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Unified Diff: content/public/browser/navigation_handle.h

Issue 2382433002: Add IsErrorPage comment noting that HTTP error pages are not included. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index 3c00e4a10afac5959e7ad7e89b67801980ffcf6d..a2b22e3e570bb8b00793ea2c7b0a5273f9912ec9 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -151,7 +151,10 @@ class CONTENT_EXPORT NavigationHandle {
// on the previous page.
virtual bool HasCommitted() = 0;
- // Whether the navigation resulted in an error page.
+ // Whether the navigation resulted in an error page. This includes
+ // browser-generated error pages, such as the 'There is no Internet
+ // connection' page, but not HTTP error pages, such as those with 4xx or 5xx
+ // response codes.
// Note that if an error page reloads, this will return true even though
// GetNetErrorCode will be net::OK.
virtual bool IsErrorPage() = 0;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698