Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 23823004: Re-enable TouchCursorInTextfieldTest with some fixes and logs (Closed)

Created:
7 years, 3 months ago by mohsen
Modified:
7 years, 3 months ago
Reviewers:
sky, varunjain
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Re-enable TouchCursorInTextfieldTest with some fixes and logs Re-enabled TouchEditableImplAuraTest.TouchCursorInTextfieldTest with two fixes: - Changed focus_textfield() in touch_seleciton.html to collapse selection after focus, since nothing should be selected after focusing the textfield. - Added a wait between dragging the handle and getting the cursor position in the test to be sure that the cursor position is updated completely. Also, added some logs in the test so that if it failed again, more data is available for investigation. BUG=235991 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221596

Patch Set 1 #

Patch Set 2 : Added a TODO to remove logs #

Total comments: 1

Patch Set 3 : Added some comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 1 4 chunks +15 lines, -4 lines 0 comments Download
M content/test/data/touch_selection.html View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mohsen
7 years, 3 months ago (2013-08-31 01:05:12 UTC) #1
varunjain
LGTM +sky for OWNERs https://codereview.chromium.org/23823004/diff/6001/content/test/data/touch_selection.html File content/test/data/touch_selection.html (right): https://codereview.chromium.org/23823004/diff/6001/content/test/data/touch_selection.html#newcode21 content/test/data/touch_selection.html:21: window.getSelection().collapseToStart(); nit: small comment on ...
7 years, 3 months ago (2013-09-05 22:34:41 UTC) #2
sky
LGTM
7 years, 3 months ago (2013-09-05 23:41:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/23823004/13001
7 years, 3 months ago (2013-09-05 23:47:33 UTC) #4
commit-bot: I haz the power
Change committed as 221596
7 years, 3 months ago (2013-09-06 06:02:57 UTC) #5
henrika (OOO until Aug 14)
7 years, 3 months ago (2013-09-06 08:58:49 UTC) #6
Message was sent while issue was closed.
Reverted. See
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
for details.

Powered by Google App Engine
This is Rietveld 408576698