chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js - Issue 23820003: Fixed JS Console Error in the Wallpaper Picker App when selecting a custom wallpaper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js

Issue 23820003: Fixed JS Console Error in the Wallpaper Picker App when selecting a custom wallpaper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wallpaper-escape-fix

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js

diff --git a/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js b/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js

index d7232175edfc5f7b4ffc724bc838e842af72ca32..9f1d66127bd692ff0e56cede6ef32df96ddb3422 100644

--- a/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js

+++ b/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js

@@ -617,7 +617,7 @@ function WallpaperManager(dialogDom) {

* @private

WallpaperManager.prototype.setWallpaperAttribution_ = function(selectedItem) {

- if (selectedItem) {

+ if (selectedItem && selectedItem.source != 'ADDNEW') {

$('author-name').textContent = selectedItem.author;

$('author-website').textContent = $('author-website').href =

selectedItem.authorWebsite;

« no previous file with comments | « no previous file | no next file » | no next file with comments »