Issue 23819038: Fix a NULL pointer access bug in TSFTextStore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23819038: Fix a NULL pointer access bug in TSFTextStore (Closed)

Created:
7 years, 3 months ago by Yohei Yukawa

Modified:
7 years, 3 months ago

Reviewers:
Yohei Yukawa, Seigo Nonaka

CC:
chromium-reviews, nona+watch_chromium.org, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix a NULL pointer access bug in TSFTextStore RequestSupportedAttrs should fail when |text_input_client_| is not available. Otherwise, we will see an access violation. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222071

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	ui/base/ime/win/tsf_text_store.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/23819038/1

7 years, 3 months ago (2013-09-09 12:16:08 UTC) #3

Message was sent while issue was closed.

Change committed as 222071

Expand Messages | Collapse Messages