Uniforms and attributes name conflicts should cause link failure

Uniforms and attributes name conflicts should cause link failure

BUG=286538
TEST=gpu_unittests, webgl conformance tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222128

[Zhenyao Mo, 2013-09-06 23:49:30]

Please review.

[Zhenyao Mo, 2013-09-06 23:50:18]

https://codereview.chromium.org/23819037/diff/1/gpu/command_buffer/service/pr...
File gpu/command_buffer/service/program_manager_unittest.cc (right):

https://codereview.chromium.org/23819037/diff/1/gpu/command_buffer/service/pr...
gpu/command_buffer/service/program_manager_unittest.cc:292: Program*
SetupShaderVariableTest(const VarInfo* vertex_variables,
I could probably turn more tests to use this function, therefore reducing code. 
Another CL.

[bajones, 2013-09-07 00:00:14]

LGTM with typo fix.

https://codereview.chromium.org/23819037/diff/1/gpu/command_buffer/service/pr...
File gpu/command_buffer/service/program_manager.cc (right):

https://codereview.chromium.org/23819037/diff/1/gpu/command_buffer/service/pr...
gpu/command_buffer/service/program_manager.cc:562: set_log_info("Name conflicts
between a varying and an attribute");
varying -> uniform

[Zhenyao Mo, 2013-09-09 19:03:08]

Ken, any further comments?

[Ken Russell (switch to Gerrit), 2013-09-09 19:20:14]

Sorry for the delay. LGTM

[commit-bot: I haz the power, 2013-09-09 19:22:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zmo@chromium.org/23819037/7001

[commit-bot: I haz the power, 2013-09-09 23:28:26]

Change committed as 222128