Give generatored bindings classes a field remembering an index into a cache of handles on the corre…

tools/dom/scripts/dartdomgenerator.py

 #!/usr/bin/python
 # Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This is the entry point to create Dart APIs from the IDL database."""
 
 import dartgenerator
 import database
 import fremontcutbuilder
@@ skipping 120 matching lines @@
         HTML_LIBRARY_NAMES, template_loader, 'dartium', dartium_output_dir)
 
     RunGenerator(dart_libraries, dart_output_dir,
                  template_loader, backend_factory)
     cpp_library_emitter.EmitDerivedSources(
         template_loader.Load('cpp_derived_sources.template'),
         dartium_output_dir)
     cpp_library_emitter.EmitResolver(
         template_loader.Load('cpp_resolver.template'), dartium_output_dir)
 
+    path = os.path.join(cpp_output_dir, 'DartClassIds.h')

[siva, 2013/09/12 18:18:20]

Can we call this file DartWebkitClassIds.h instead of DartClassIds.h to make
that more explicit.

+    e = emitters.FileEmitter(path)
+    e.Emit("""
+// WARNING: Do not edit - generated code.
+
+#ifndef DartClassIds_h
+#define DartClassIds_h

[siva, 2013/09/12 18:18:20]

DartWebkitClassIds_h

+
+namespace WebCore {
+
+enum {
+    _HistoryCrossFrameClassId = 0,
+    _LocationCrossFrameClassId,
+    _DOMWindowCrossFrameClassId,
+    _NPObjectClassId,

[siva, 2013/09/12 18:18:20]

We should add a comment here that whenever new types are introduced which are
not in the auto generated list they need to be added here too.

+""")
+    for interface in webkit_database.GetInterfaces():
+      interface_name = interface.id
+      e.Emit('    %sClassId,\n' % interface_name)
+    e.Emit("""
+    NumClassIds

[siva, 2013/09/12 18:18:20]

kNumWebKitClassIds maybe for this maybe.

+};
+
+} // namespace WebCore
+
+#endif // DartClassIds_h

[siva, 2013/09/12 18:18:20]

Ditto comment

+""")
+
   _logger.info('Flush...')
   emitters.Flush()
 
   if update_dom_metadata:
     metadata.Flush()
 
   monitored.FinishMonitoring(dart2js_output_dir)
 
 def GenerateSingleFile(library_path, output_dir, generated_output_dir=None):
   library_dir = os.path.dirname(library_path)
@@ skipping 65 matching lines @@
           os.path.join('..', '..', '..', 'sdk', 'lib', library_name, 'dart2js'))
   if 'htmldartium' in systems:
     _logger.info('Generating dartium single files.')
     for library_name in HTML_LIBRARY_NAMES:
       GenerateSingleFile(
           os.path.join(dartium_output_dir, '%s_dartium.dart' % library_name),
           os.path.join('..', '..', '..', 'sdk', 'lib', library_name, 'dartium'))
 
 if __name__ == '__main__':
   sys.exit(main())