Dynamically load keyboard layouts.

Dynamically load keyboard layouts.

BUG=260278
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222111

[kevers, 2013-09-06 20:42:41]

Hi Biao,

Can you please take a look at this CL.

[bshe, 2013-09-06 21:12:21]

lgtm

it might be good to have someone in polymer team to take a look as well?

https://codereview.chromium.org/23819032/diff/5001/ui/keyboard/resources/elem...
File ui/keyboard/resources/elements/kb-keyboard.html (right):

https://codereview.chromium.org/23819032/diff/5001/ui/keyboard/resources/elem...
ui/keyboard/resources/elements/kb-keyboard.html:496:
HTMLImports.parser.parseLink(link);
would it enter infinite loop if failed to load?

https://codereview.chromium.org/23819032/diff/5001/ui/keyboard/resources/inde...
File ui/keyboard/resources/index.html (right):

https://codereview.chromium.org/23819032/diff/5001/ui/keyboard/resources/inde...
ui/keyboard/resources/index.html:36: -- inserted here.
If I understand correctly, it seems we can't load new custom element in the
layout file? Do you think it is worth to file a new bug for it? Or maybe mention
it in a comment?

[kevers, 2013-09-09 15:44:03]

https://codereview.chromium.org/23819032/diff/5001/ui/keyboard/resources/elem...
File ui/keyboard/resources/elements/kb-keyboard.html (right):

https://codereview.chromium.org/23819032/diff/5001/ui/keyboard/resources/elem...
ui/keyboard/resources/elements/kb-keyboard.html:496:
HTMLImports.parser.parseLink(link);
On 2013/09/06 21:12:21, bshe wrote:
> would it enter infinite loop if failed to load?

We do a check for an existing link element before injecting a new link.  If the
load fails, the next call to layoutChanged will detect that a link element was
already added and not do any extra recursion.

https://codereview.chromium.org/23819032/diff/5001/ui/keyboard/resources/inde...
File ui/keyboard/resources/index.html (right):

https://codereview.chromium.org/23819032/diff/5001/ui/keyboard/resources/inde...
ui/keyboard/resources/index.html:36: -- inserted here.
On 2013/09/06 21:12:21, bshe wrote:
> If I understand correctly, it seems we can't load new custom element in the
> layout file? Do you think it is worth to file a new bug for it? Or maybe
mention
> it in a comment?

I believe the problem was that two of the elements we were trying to dynamically
load were being referenced from outside the layout html.  The spacebar element
is still dynamically loaded from inside the layout and does not present a
problem.

[commit-bot: I haz the power, 2013-09-09 16:56:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/23819032/5001

[commit-bot: I haz the power, 2013-09-09 22:27:19]

Change committed as 222111