Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: Source/wtf/tests/WTFString.cpp

Issue 23819029: String vector's comparison works wrong (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/wtf/text/WTFString.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 ASSERT_FALSE(testString.is8Bit()); 147 ASSERT_FALSE(testString.is8Bit());
148 testString.replaceWithLiteral(UChar(0x00E9 /*U+00E9 is 'é'*/), ""); 148 testString.replaceWithLiteral(UChar(0x00E9 /*U+00E9 is 'é'*/), "");
149 ASSERT_STREQ("rsum", testString.utf8().data()); 149 ASSERT_STREQ("rsum", testString.utf8().data());
150 150
151 testString = String::fromUTF8("résumé"); 151 testString = String::fromUTF8("résumé");
152 ASSERT_FALSE(testString.is8Bit()); 152 ASSERT_FALSE(testString.is8Bit());
153 testString.replaceWithLiteral('3', "NotFound"); 153 testString.replaceWithLiteral('3', "NotFound");
154 ASSERT_STREQ("résumé", testString.utf8().data()); 154 ASSERT_STREQ("résumé", testString.utf8().data());
155 } 155 }
156 156
157 TEST(WTF, StringComparisonOfSameStringVectors)
158 {
159 Vector<String> stringVector;
160 stringVector.append("one");
161 stringVector.append("two");
162
163 Vector<String> sameStringVector;
164 sameStringVector.append("one");
165 sameStringVector.append("two");
166
167 ASSERT_EQ(stringVector, sameStringVector);
168 }
169
157 } // namespace 170 } // namespace
OLDNEW
« no previous file with comments | « no previous file | Source/wtf/text/WTFString.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698