Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 23819025: Simple Cache: restore the high-res timer (Closed)

Created:
7 years, 3 months ago by pasko
Modified:
7 years, 3 months ago
Reviewers:
Philippe, gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Visibility:
Public.

Description

Simple Cache: restore the high-res timer This *reverts* the parts of high-res timing that was moved out from simple cache in attempt to have it in base/, here: http://src.chromium.org/viewvc/chrome?view=revision&revision=216478 The changes in base/ are untouched today. This partial revert should be safe because this change just adds (un-removes) a different implementation and switches simple cache to using it. The bug being blocked by this deficiency is in the BUG field, we do not have a specific bug for the problem, it would have required age restriction on the audience. BUG=261618 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221492

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
M net/disk_cache/simple/simple_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_util.cc View 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pasko
this will likely finally fix the time resolution problems
7 years, 3 months ago (2013-09-05 14:37:56 UTC) #1
Philippe
lgtm, thanks Egor!
7 years, 3 months ago (2013-09-05 14:46:52 UTC) #2
gavinp
LGTM. Good catch Egor. Ugh. TIming is hard.
7 years, 3 months ago (2013-09-05 14:50:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pasko@chromium.org/23819025/1
7 years, 3 months ago (2013-09-05 14:51:18 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 19:21:28 UTC) #5
Message was sent while issue was closed.
Change committed as 221492

Powered by Google App Engine
This is Rietveld 408576698