Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: Source/core/rendering/RenderView.cpp

Issue 23819019: Refactor fixed layout mode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: git rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderView.cpp
diff --git a/Source/core/rendering/RenderView.cpp b/Source/core/rendering/RenderView.cpp
index 550ca4ed052947493a36921dcf7d8f298ed286b6..45dfa97dc8de8b829cd613287d3aa2b76db352f7 100644
--- a/Source/core/rendering/RenderView.cpp
+++ b/Source/core/rendering/RenderView.cpp
@@ -1019,27 +1019,25 @@ IntRect RenderView::documentRect() const
return IntRect(overflowRect);
}
-int RenderView::viewHeight(ScrollableArea::VisibleContentRectIncludesScrollbars scrollbarInclusion) const
+int RenderView::viewHeight(ScrollableArea::IncludeScrollbarsInRect scrollbarInclusion) const
{
int height = 0;
- if (!shouldUsePrintingLayout() && m_frameView) {
- height = m_frameView->layoutHeight(scrollbarInclusion);
- height = m_frameView->useFixedLayout() ? ceilf(style()->effectiveZoom() * float(height)) : height;
- }
+ if (!shouldUsePrintingLayout() && m_frameView)
+ height = m_frameView->layoutSize(scrollbarInclusion).height();
+
return height;
}
-int RenderView::viewWidth(ScrollableArea::VisibleContentRectIncludesScrollbars scrollbarInclusion) const
+int RenderView::viewWidth(ScrollableArea::IncludeScrollbarsInRect scrollbarInclusion) const
{
int width = 0;
- if (!shouldUsePrintingLayout() && m_frameView) {
- width = m_frameView->layoutWidth(scrollbarInclusion);
- width = m_frameView->useFixedLayout() ? ceilf(style()->effectiveZoom() * float(width)) : width;
- }
+ if (!shouldUsePrintingLayout() && m_frameView)
+ width = m_frameView->layoutSize(scrollbarInclusion).width();
+
return width;
}
-int RenderView::viewLogicalHeight(ScrollableArea::VisibleContentRectIncludesScrollbars scrollbarInclusion) const
+int RenderView::viewLogicalHeight(ScrollableArea::IncludeScrollbarsInRect scrollbarInclusion) const
{
int height = style()->isHorizontalWritingMode() ? viewHeight(scrollbarInclusion) : viewWidth(scrollbarInclusion);

Powered by Google App Engine
This is Rietveld 408576698