LayoutTests/fast/events/resize-events.html - Issue 23819019: Refactor fixed layout mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/events/resize-events.html

Issue 23819019: Refactor fixed layout mode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: git rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/TestExpectations ('K') | « LayoutTests/css3/device-adapt/viewport-user-agent-style.html ('k') | LayoutTests/fast/events/resize-events-expected.txt » ('j') | Source/core/page/FrameView.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/events/resize-events.html

diff --git a/LayoutTests/fast/events/resize-events.html b/LayoutTests/fast/events/resize-events.html

index c5ca3d110d8b44e480b30c6d210085d225909f8d..b6f8b72e93f0956d3d949f59645d1ce0fa2ac477 100644

--- a/LayoutTests/fast/events/resize-events.html

+++ b/LayoutTests/fast/events/resize-events.html

@@ -7,7 +7,7 @@

</head>

<body>

<div>

- Following actions must not emit resize events: page load, dynamic content generation, page scaling and changing fixed layout size.<br/>

+ Following actions must not emit resize events: page load, dynamic content generation, and page scaling.<br/>

The spec DOM Level 2 Events states that the resize event occurs when document view size (a.k.a layout size) is changed. Refer to http://www.w3.org/TR/DOM-Level-2-Events/events.html<br/>

However, showing/hiding scrollbars shouldn't be considered a layout size change. Refer to webkit.org/b/80242<br/>

@@ -41,11 +41,6 @@

function scalePage() {

if (window.eventSender)

window.eventSender.setPageScaleFactor(3, 0, 0);

- setTimeout(changeFixedLayoutSize, 20);

- }

- function changeFixedLayoutSize() {

- if (window.testRunner)

- testRunner.setFixedLayoutSize(1600, 1600);

setTimeout(finish, 20);

}

function finish() {