Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 23818003: Revert "Allow configuring CPU profiler sampling interval" (Closed)

Created:
7 years, 3 months ago by epenner
Modified:
7 years, 3 months ago
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, do-not-use, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert "Allow configuring CPU profiler sampling interval" This reverts commit 4933abfbd2cdc88443cd0c57b8a90dd27ce48ec2. BUG=284998 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -44 lines) Patch
M Source/bindings/v8/ScriptProfiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/ScriptProfiler.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/devtools/front_end/ProfilesPanel.js View 2 chunks +0 lines, -14 lines 0 comments Download
M Source/devtools/front_end/Settings.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/SettingsScreen.js View 2 chunks +1 line, -3 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
epenner
Ptal. Unfortunately we need to roll back V8 (see bug) and this uses a new ...
7 years, 3 months ago (2013-09-06 05:30:26 UTC) #1
yurys
lgtm
7 years, 3 months ago (2013-09-06 05:37:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/23818003/1
7 years, 3 months ago (2013-09-06 05:50:31 UTC) #3
epennerAtGoogle
On 2013/09/06 05:37:16, Yury Semikhatsky wrote: > lgtm Thanks Yury and apologies for the inconvenience. ...
7 years, 3 months ago (2013-09-06 05:51:15 UTC) #4
yurys
You'll need to update Blink deps in Chromium until that the change is not there
7 years, 3 months ago (2013-09-06 06:14:23 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 08:43:00 UTC) #6
Message was sent while issue was closed.
Change committed as 157359

Powered by Google App Engine
This is Rietveld 408576698