Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 23816008: Drop CSS cursor quirk for missing fallback cursor. (Closed)

Created:
7 years, 3 months ago by rune
Modified:
7 years, 3 months ago
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Drop CSS cursor quirk for missing fallback cursor. IE used to allow URI cursors without a specified pre-defined cursor value fallback. This CL removes the support for that quirk because IE allegedly dropped this quirk in IE9, even in the compat modes (see issue 286668). Made the existing parsing tests run in strict mode and moved test cases for quirks mode to a new file. The 'hand' -> 'pointer' quirk was not touched. R=tabatkins@google.com BUG=286668 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157918

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Added default pointer fallback to cursor rule in http test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -17 lines) Patch
M LayoutTests/fast/css/cursor-parsing.html View 3 chunks +3 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/cursor-parsing-expected.txt View 2 chunks +2 lines, -1 line 0 comments Download
A LayoutTests/fast/css/cursor-parsing-quirks.html View 1 chunk +52 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/cursor-parsing-quirks-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/invalid-cursor-property-crash.html View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/uri-token-parsing.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/uri-token-parsing-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/misc/clone-in-DOMContentLoaded.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSParser-in.cpp View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rune
7 years, 3 months ago (2013-09-09 11:58:29 UTC) #1
TabAtkins
lgtm
7 years, 3 months ago (2013-09-16 17:47:52 UTC) #2
rune
7 years, 3 months ago (2013-09-17 07:27:59 UTC) #3
jochen (gone - plz use gerrit)
lgtm
7 years, 3 months ago (2013-09-17 08:34:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/23816008/1
7 years, 3 months ago (2013-09-17 08:57:09 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=5056
7 years, 3 months ago (2013-09-17 10:24:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/23816008/22001
7 years, 3 months ago (2013-09-17 21:37:56 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 22:49:17 UTC) #8
Message was sent while issue was closed.
Change committed as 157918

Powered by Google App Engine
This is Rietveld 408576698