Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
23816006:
Exclude networking_private_crypto.cc and networking_private_crypto_unittest.cc (Closed)
|
Created:
7 years, 3 months ago by wtc Modified:
7 years, 3 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src/ Visibility:
Public. |
DescriptionExclude networking_private_crypto.cc and networking_private_crypto_unittest.cc
from use_openssl=1 builds because networking_private_crypto.cc uses NSS
functions.
R=mef@chromium.org,rsleevi@chromium.org
BUG=267667
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222056
Patch Set 1 #
Messages
Total messages: 9 (0 generated)
Here is an example of the compilation error on the linux_redux build bot (which sets use_openssl=1): http://build.chromium.org/p/tryserver.chromium/builders/linux_redux/builds/10... FAILED: g++ -MMD -MF obj/chrome/browser/extensions/api/networking_private/browser_extensions.networking_private_crypto.o.d -DANGLE_DX11 -DWTF_VECTOR_INITIAL_SIZE=4 -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DENABLE_ONE_CLICK_SIGNIN -DGTK_DISABLE_SINGLE_INCLUDES=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_GPU=1 -DUSE_OPENSSL=1 -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DGL_GLEXT_PROTOTYPES -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DJSONCPP_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DLINUX -DPOSIX -DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION -DUSE_GCONF -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -I../.. -Iobj/chrome/browser_extensions.gen -I../../third_party/khronos -I../../gpu -Igen/chrome -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -I../../third_party/sqlite -Igen -I../../third_party/skia/src/core -I../../skia/config -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc -I../../third_party/jsoncpp/overrides/include -I../../third_party/jsoncpp/source/include -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/leveldatabase/src/include -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase -I../../third_party/libusb/src/libusb -I../../third_party/re2 -Igen/ui/app_locale_settings -Igen/ui/ui_strings -Igen/ui/ui_resources -Igen/webkit -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -pthread -I/usr/include/gconf/2 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread -I/usr/include/gtk-unix-print-2.0 -I/usr/include/gtk-2.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -O2 -fno-ident -fdata-sections -ffunction-sections -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -c ../../chrome/browser/extensions/api/networking_private/networking_private_crypto.cc -o obj/chrome/browser/extensions/api/networking_private/browser_extensions.networking_private_crypto.o ../../chrome/browser/extensions/api/networking_private/networking_private_crypto.cc:7:18: fatal error: cert.h: No such file or directory
LGTM
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/23816006/1
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
On 2013/09/07 01:06:18, wtc wrote: > Here is an example of the compilation error on the linux_redux > build bot (which sets use_openssl=1): > > http://build.chromium.org/p/tryserver.chromium/builders/linux_redux/builds/10... > > FAILED: g++ -MMD -MF > obj/chrome/browser/extensions/api/networking_private/browser_extensions.networking_private_crypto.o.d > -DANGLE_DX11 -DWTF_VECTOR_INITIAL_SIZE=4 -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC > -DDISABLE_NACL -DCHROMIUM_BUILD -DUSE_DEFAULT_RENDER_THEME=1 > -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DENABLE_ONE_CLICK_SIGNIN > -DGTK_DISABLE_SINGLE_INCLUDES=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS > -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_GPU=1 -DUSE_OPENSSL=1 > -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 > -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 > -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 > -DENABLE_GOOGLE_NOW=1 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 > -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 > -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DGL_GLEXT_PROTOTYPES > -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI > -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_ENABLE_INST_COUNT=0 > -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' > -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 > -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH > -DGTEST_RELATIVE_PATH -DJSONCPP_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING > -DNO_SOUND_SYSTEM -DLINUX -DPOSIX -DU_USING_ICU_NAMESPACE=0 > -DU_STATIC_IMPLEMENTATION -DUSE_GCONF -D__STDC_CONSTANT_MACROS > -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 > -D_FORTIFY_SOURCE=2 -I../.. -Iobj/chrome/browser_extensions.gen > -I../../third_party/khronos -I../../gpu -Igen/chrome -Igen/protoc_out > -I../../third_party/protobuf -I../../third_party/protobuf/src > -I../../third_party/sqlite -Igen -I../../third_party/skia/src/core > -I../../skia/config -I../../third_party/skia/include/config > -I../../third_party/skia/include/core -I../../third_party/skia/include/effects > -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu > -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops > -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports > -I../../third_party/skia/include/utils -I../../skia/ext > -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source > -I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc > -I../../third_party/jsoncpp/overrides/include > -I../../third_party/jsoncpp/source/include > -I../../third_party/cacheinvalidation/overrides > -I../../third_party/cacheinvalidation/src -I../../third_party/icu/source/i18n > -I../../third_party/icu/source/common > -I../../third_party/leveldatabase/src/include > -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase > -I../../third_party/libusb/src/libusb -I../../third_party/re2 > -Igen/ui/app_locale_settings -Igen/ui/ui_strings -Igen/ui/ui_resources > -Igen/webkit -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread > -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter > -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -pthread > -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include > -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include > -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 > -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/pixman-1 > -I/usr/include/freetype2 -I/usr/include/libpng12 -pthread > -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include > -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -pthread > -I/usr/include/gconf/2 -I/usr/include/dbus-1.0 > -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/glib-2.0 > -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread > -I/usr/include/gtk-unix-print-2.0 -I/usr/include/gtk-2.0 -I/usr/include/atk-1.0 > -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 > -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/gio-unix-2.0/ > -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include > -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -O2 > -fno-ident -fdata-sections -ffunction-sections -fno-rtti -fno-threadsafe-statics > -fvisibility-inlines-hidden -Wsign-compare -c > ../../chrome/browser/extensions/api/networking_private/networking_private_crypto.cc > -o > obj/chrome/browser/extensions/api/networking_private/browser_extensions.networking_private_crypto.o > ../../chrome/browser/extensions/api/networking_private/networking_private_crypto.cc:7:18: > fatal error: cert.h: No such file or directory LGTM, thanks for fixing it! Sorry that I've missed that, should I have ran some additional tests prior to commit?
On 2013/09/09 10:42:57, mef wrote: > > LGTM, thanks for fixing it! > Sorry that I've missed that, should I have ran some additional tests prior to > commit? No problem. The use_openssl=1 build is tested by the 'linux_redux' buildbot. Since this build configuration is not regularly used, I think the 'linux_redux' buildbot is only run when a CL seems related to NSS or OpenSSL. Also, I found that the commit queue doesn't run the 'linux_redux' bot, only "gcl try" does. So I am afraid that you could not have anticipated this. You can manually run "gcl try --bot linux_redux" if you know your CL uses NSS or OpenSSL.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/23816006/1
Message was sent while issue was closed.
Change committed as 222056 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
