Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23811008: [android] Remove deprecated package constants. (Closed)

Created:
7 years, 3 months ago by craigdh
Modified:
7 years, 3 months ago
Reviewers:
bulach, Isaac (away), frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[android] Remove deprecated package constants. NOTE: Do not land before corresponding downstream patch. BUG=260494 TEST=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223670

Patch Set 1 #

Total comments: 2

Patch Set 2 : moved beta and stable packages to PACKAGE_INFO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -31 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M build/android/pylib/constants.py View 1 3 chunks +23 lines, -27 lines 0 comments Download
M tools/android/memdump/memreport.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
craigdh
+ilevy for buildbot OWNERS
7 years, 3 months ago (2013-09-12 23:02:58 UTC) #1
craigdh
+bulach for tools/android/ OWNERS
7 years, 3 months ago (2013-09-12 23:03:52 UTC) #2
craigdh
7 years, 3 months ago (2013-09-12 23:04:28 UTC) #3
frankf
lgtm
7 years, 3 months ago (2013-09-12 23:06:26 UTC) #4
bulach
lgtm, thanks!
7 years, 3 months ago (2013-09-13 10:35:05 UTC) #5
Isaac (away)
lgtm
7 years, 3 months ago (2013-09-13 11:24:03 UTC) #6
frankf
https://codereview.chromium.org/23811008/diff/1/build/android/pylib/constants.py File build/android/pylib/constants.py (right): https://codereview.chromium.org/23811008/diff/1/build/android/pylib/constants.py#newcode20 build/android/pylib/constants.py:20: CHROME_BETA_PACKAGE = 'com.chrome.beta' It'd be good to include the ...
7 years, 3 months ago (2013-09-13 17:32:55 UTC) #7
craigdh
https://codereview.chromium.org/23811008/diff/1/build/android/pylib/constants.py File build/android/pylib/constants.py (right): https://codereview.chromium.org/23811008/diff/1/build/android/pylib/constants.py#newcode20 build/android/pylib/constants.py:20: CHROME_BETA_PACKAGE = 'com.chrome.beta' On 2013/09/13 17:32:56, frankf wrote: > ...
7 years, 3 months ago (2013-09-16 18:30:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/23811008/14001
7 years, 3 months ago (2013-09-17 20:12:45 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 20:17:09 UTC) #10
Message was sent while issue was closed. 
Change committed as 223670

Powered by Google App Engine
This is Rietveld 408576698