Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 2380943002: Tell renderer which subframes have history items on back/forward. (Closed)
Patch Set: Fix const ref. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/common/navigation_params.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 1078 matching lines...) Expand 10 before | Expand all | Expand 10 after
1089 // Non-null when the RenderFrame is a local root for compositing, input, 1089 // Non-null when the RenderFrame is a local root for compositing, input,
1090 // layout, etc. A local frame is also a local root iff it does not have a 1090 // layout, etc. A local frame is also a local root iff it does not have a
1091 // parent that is a local frame. 1091 // parent that is a local frame.
1092 scoped_refptr<RenderWidget> render_widget_; 1092 scoped_refptr<RenderWidget> render_widget_;
1093 1093
1094 // Temporarily holds state pertaining to a navigation that has been initiated 1094 // Temporarily holds state pertaining to a navigation that has been initiated
1095 // until the NavigationState corresponding to the new navigation is created in 1095 // until the NavigationState corresponding to the new navigation is created in
1096 // didCreateDataSource(). 1096 // didCreateDataSource().
1097 std::unique_ptr<NavigationParams> pending_navigation_params_; 1097 std::unique_ptr<NavigationParams> pending_navigation_params_;
1098 1098
1099 // Keeps track of whether the browser process has any history items that need 1099 // Keeps track of which future subframes the browser process has history items
1100 // to be used for subframes of this frame (in the case of a history 1100 // for during a history navigation. The renderer process should ask the
1101 // navigation). If not, the renderer can skip sending an IPC to the browser 1101 // browser for history items when subframes with these names are created, and
1102 // and directly load any initial URLs for children itself. This state is 1102 // directly load the initial URLs for any other subframes. This state is
1103 // cleared during didStopLoading, since it is not needed after the first load 1103 // incrementally cleared as it is used and then reset in didStopLoading, since
1104 // completes and is never used after the initial navigation. It is inherited 1104 // it is not needed after the first load completes and is never used after the
1105 // by subframes. 1105 // initial navigation.
1106 // TODO(creis): Switch this to a data structure of unique names and 1106 // TODO(creis): Expand this to include any corresponding same-process
1107 // corresponding same-process PageStates in https://crbug.com/639842. 1107 // PageStates for the whole subtree in https://crbug.com/639842.
1108 bool browser_has_subtree_history_items_; 1108 std::set<std::string> history_subframe_unique_names_;
1109 1109
1110 // Stores the current history item for this frame, so that updates to it can 1110 // Stores the current history item for this frame, so that updates to it can
1111 // be reported to the browser process via SendUpdateState. 1111 // be reported to the browser process via SendUpdateState.
1112 blink::WebHistoryItem current_history_item_; 1112 blink::WebHistoryItem current_history_item_;
1113 1113
1114 #if defined(ENABLE_PLUGINS) 1114 #if defined(ENABLE_PLUGINS)
1115 // Current text input composition text. Empty if no composition is in 1115 // Current text input composition text. Empty if no composition is in
1116 // progress. 1116 // progress.
1117 base::string16 pepper_composition_text_; 1117 base::string16 pepper_composition_text_;
1118 1118
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
1301 remote_associated_interfaces_; 1301 remote_associated_interfaces_;
1302 1302
1303 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 1303 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
1304 1304
1305 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 1305 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
1306 }; 1306 };
1307 1307
1308 } // namespace content 1308 } // namespace content
1309 1309
1310 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 1310 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW
« no previous file with comments | « content/common/navigation_params.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698