[PPAPI] ResourceVar now reference counts its PP_Resource in the plugin.

ppapi/shared_impl/unittest_utils.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/shared_impl/unittest_utils.h"
 
 #include <cmath>
 
 #include "base/containers/hash_tables.h"
 #include "base/logging.h"
+#include "ipc/ipc_message.h"
 #include "ppapi/shared_impl/array_var.h"
 #include "ppapi/shared_impl/dictionary_var.h"
 #include "ppapi/shared_impl/resource_var.h"
 #include "ppapi/shared_impl/var.h"
 #include "ppapi/shared_impl/var_tracker.h"
 
 namespace ppapi {
 
 namespace {
 
@@ skipping 128 matching lines @@
                     visited_map)) {
           return false;
         }
       }
       return true;
     }
     case PP_VARTYPE_RESOURCE: {
       ResourceVar* expected_var = ResourceVar::FromPPVar(expected);
       ResourceVar* actual_var = ResourceVar::FromPPVar(actual);
       DCHECK(expected_var && actual_var);
-      if (expected_var->pp_resource() != actual_var->pp_resource()) {
-        LOG(ERROR) << "expected: " << expected_var->pp_resource() << " actual: "
-                   << actual_var->pp_resource();
-        return false;
-      }
-      IPC::Message actual_message(actual_var->creation_message());
-      const IPC::Message& expected_message = expected_var->creation_message();
-      if (expected_message.size() != actual_message.size()) {
-        LOG(ERROR) << "expected creation message size: "
-                   << expected_message.size() << " actual: "
-                   << actual_message.size();
+      if (expected_var->GetPPResource() != actual_var->GetPPResource()) {
+        LOG(ERROR) << "expected: " << expected_var->GetPPResource()
+                   << " actual: " << actual_var->GetPPResource();
         return false;
       }
 
+      const IPC::Message* actual_message = actual_var->GetCreationMessage();
+      const IPC::Message* expected_message =
+          expected_var->GetCreationMessage();
+      if (expected_message->size() != actual_message->size()) {
+        LOG(ERROR) << "expected creation message size: "
+                   << expected_message->size() << " actual: "
+                   << actual_message->size();
+        return false;
+      }
+
       // Set the upper 24 bits of actual creation_message flags to the same as
       // expected. This is an unpredictable reference number that changes
       // between serialization/deserialization, and we do not want it to cause
       // the comparison to fail.
-      actual_message.SetHeaderValues(actual_message.routing_id(),
-                                     actual_message.type(),
-                                     (expected_message.flags() & 0xffffff00) |
-                                      (actual_message.flags() & 0xff));
-      if (memcmp(expected_message.data(), actual_message.data(),
-                 expected_message.size()) != 0) {
+      IPC::Message local_actual_message(*actual_message);
+      local_actual_message.SetHeaderValues(
+          actual_message->routing_id(), actual_message->type(),
+          (expected_message->flags() & 0xffffff00) |
+           (actual_message->flags() & 0xff));
+      if (memcmp(expected_message->data(), local_actual_message.data(),
+                 expected_message->size()) != 0) {
         LOG(ERROR) << "expected creation message does not match actual.";
         return false;
       }
       return true;
     }
   }
   NOTREACHED();
   return false;
 }
 
 }  // namespace
 
 bool TestEqual(const PP_Var& expected, const PP_Var& actual) {
   base::hash_map<int64_t, int64_t> visited_map;
   return Equals(expected, actual, &visited_map);
 }
 
 }  // namespace ppapi