Issue 23809010: Fix YUVConvert unittest failure on Android_X86.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23809010: Fix YUVConvert unittest failure on Android_X86. (Closed)

Created:
7 years, 3 months ago by hkuang

Modified:
7 years, 3 months ago

Reviewers:
wjia(left Chromium), fgalligan1, scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Fix YUVConvert unittest failure on Android_X86. This will also fix the WebRTC color bug fixed before on ARM: https://codereview.chromium.org/17043007/ BUG=262319 TEST= Visit inear.se/bgra on Android_X86 phone. Color is right. Run media unittest on both ARM and x86, both passed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222057

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -12 lines)			Patch
M	media/base/simd/convert_rgb_to_yuv_sse2.cc	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	media/base/simd/convert_yuv_to_rgb_c.cc	View	1 chunk	+20 lines, -12 lines	0 comments	Download
M	media/base/simd/yuv_to_rgb_table.cc	View	1 chunk	+22 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hkuang@chromium.org/23809010/1

7 years, 3 months ago (2013-09-07 00:45:43 UTC) #4

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 3 months ago (2013-09-07 01:02:38 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hkuang@chromium.org/23809010/1

7 years, 3 months ago (2013-09-09 17:54:51 UTC) #6

Message was sent while issue was closed.

Change committed as 222057