Issue 23809007: Refactor the viewport code to be more understandable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23809007: Refactor the viewport code to be more understandable (Closed)

Created:
7 years, 3 months ago by kenneth.r.christiansen

Modified:
7 years, 3 months ago

Reviewers:
abarth-chromium, Mike West, rune, eseidel

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Refactor the viewport code to be more understandable Introduce a shouldOverrideLegacyViewport method and use it instead of comparing types manually. Make the setViewportArguments method handle both legacy and @viewport, instead of just the latter. Now the code is a bit more self documenting, so reword some of the comments. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157366

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -38 lines)			Patch
	M	Source/core/dom/Document.h	View		2 chunks	+6 lines, -8 lines	0 comments	Download
	M	Source/core/dom/Document.cpp	View		1 chunk	+44 lines, -30 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/23809007/1

7 years, 3 months ago (2013-09-06 12:15:24 UTC) #4

Message was sent while issue was closed.

Change committed as 157366

Expand Messages | Collapse Messages