Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23806003: Use PP_ArrayOutput and PPB_NetAddress in PPB_NetworkList_Private.. (Closed)

Created:
7 years, 3 months ago by Sergey Ulanov
Modified:
7 years, 3 months ago
Reviewers:
yzshen1, piman
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, yusukes+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, raymes+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, yzshen+watch_chromium.org, weitaosu+watch_chromium.org, piman+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Use PP_ArrayOutput and PPB_NetAddress in PPB_NetworkList_Private.. PPB_NetworkList_Private was implemented before PP_ArrayOutput and PPB_NetAddress was added. Refactor GetIPAddress() to use these new types. Also removed in-process support because PPB_NetAddress doesn't support in-process mode. BUG=281781 TBR=piman@chromium.org (trivial changes in content_renderer.gypi) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221324

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 20

Patch Set 6 : #

Total comments: 2

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -382 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 6 7 1 chunk +0 lines, -2 lines 0 comments Download
D content/renderer/pepper/ppb_network_monitor_private_impl.h View 1 2 3 4 1 chunk +0 lines, -50 lines 0 comments Download
D content/renderer/pepper/ppb_network_monitor_private_impl.cc View 1 2 3 4 1 chunk +0 lines, -108 lines 0 comments Download
M content/renderer/pepper/resource_creation_impl.cc View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/api/private/ppb_network_list_private.idl View 1 2 3 4 5 6 6 chunks +50 lines, -14 lines 0 comments Download
M ppapi/c/private/ppb_network_list_private.h View 1 2 3 4 5 6 3 chunks +53 lines, -16 lines 0 comments Download
M ppapi/cpp/private/network_list_private.h View 1 2 3 4 5 2 chunks +4 lines, -2 lines 0 comments Download
M ppapi/cpp/private/network_list_private.cc View 1 2 3 4 5 6 7 8 2 chunks +29 lines, -45 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 2 3 4 5 6 7 5 chunks +33 lines, -33 lines 0 comments Download
M ppapi/shared_impl/ppb_network_list_private_shared.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/ppb_network_list_private_shared.cc View 1 2 3 4 5 2 chunks +22 lines, -8 lines 0 comments Download
M ppapi/tests/test_network_monitor_private.cc View 1 2 3 4 5 3 chunks +44 lines, -47 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_private_no_permissions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_network_list_api.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/thunk/ppb_network_list_private_thunk.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M remoting/client/plugin/pepper_network_manager.cc View 1 2 3 2 chunks +10 lines, -34 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Sergey Ulanov
7 years, 3 months ago (2013-08-30 19:56:24 UTC) #1
Sergey Ulanov
As I mentioned in the other CL only chromoting client plugin uses this interface and ...
7 years, 3 months ago (2013-08-30 19:59:46 UTC) #2
yzshen1
https://codereview.chromium.org/23806003/diff/24001/ppapi/api/private/ppb_network_list_private.idl File ppapi/api/private/ppb_network_list_private.idl (right): https://codereview.chromium.org/23806003/diff/24001/ppapi/api/private/ppb_network_list_private.idl#newcode110 ppapi/api/private/ppb_network_list_private.idl:110: * @param[in] resource A <code>PP_Resource</code> corresponding to a It ...
7 years, 3 months ago (2013-09-03 17:47:32 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/23806003/diff/24001/ppapi/api/private/ppb_network_list_private.idl File ppapi/api/private/ppb_network_list_private.idl (right): https://codereview.chromium.org/23806003/diff/24001/ppapi/api/private/ppb_network_list_private.idl#newcode110 ppapi/api/private/ppb_network_list_private.idl:110: * @param[in] resource A <code>PP_Resource</code> corresponding to a On ...
7 years, 3 months ago (2013-09-03 23:42:53 UTC) #4
yzshen1
LGTM Thanks! https://codereview.chromium.org/23806003/diff/58001/ppapi/api/private/ppb_network_list_private.idl File ppapi/api/private/ppb_network_list_private.idl (right): https://codereview.chromium.org/23806003/diff/58001/ppapi/api/private/ppb_network_list_private.idl#newcode80 ppapi/api/private/ppb_network_list_private.idl:80: * nit: to be consistent, please consider ...
7 years, 3 months ago (2013-09-04 17:40:26 UTC) #5
Sergey Ulanov
https://codereview.chromium.org/23806003/diff/58001/ppapi/api/private/ppb_network_list_private.idl File ppapi/api/private/ppb_network_list_private.idl (right): https://codereview.chromium.org/23806003/diff/58001/ppapi/api/private/ppb_network_list_private.idl#newcode80 ppapi/api/private/ppb_network_list_private.idl:80: * On 2013/09/04 17:40:26, yzshen1 wrote: > nit: to ...
7 years, 3 months ago (2013-09-04 18:43:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23806003/78001
7 years, 3 months ago (2013-09-04 18:44:16 UTC) #7
commit-bot: I haz the power
Failed to apply patch for ppapi/c/pp_macros.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-04 18:44:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23806003/81001
7 years, 3 months ago (2013-09-04 18:49:31 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=23740
7 years, 3 months ago (2013-09-04 19:11:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23806003/81001
7 years, 3 months ago (2013-09-04 19:16:44 UTC) #11
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=23746
7 years, 3 months ago (2013-09-04 19:31:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23806003/94001
7 years, 3 months ago (2013-09-04 19:38:50 UTC) #13
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 01:06:49 UTC) #14
Message was sent while issue was closed. 
Change committed as 221324

Powered by Google App Engine
This is Rietveld 408576698