Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23803008: libosmesa.so should have static glapi linkage (Closed)

Created:
7 years, 3 months ago by trchen
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

libosmesa.so should have static glapi linkage Define _GLAPI_NO_EXPORTS for all platforms. BUG=286467 R=kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/mesa/mesa.gyp View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
trchen
Hello, this patch fixes symbol collision on newer Linux systems. PTAL!
7 years, 3 months ago (2013-09-06 21:25:14 UTC) #1
Ken Russell (switch to Gerrit)
LGTM assuming this doesn't break anything on the other platforms.
7 years, 3 months ago (2013-09-06 21:35:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/23803008/1
7 years, 3 months ago (2013-09-06 21:39:43 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-07 01:02:37 UTC) #4
Message was sent while issue was closed. 
Change committed as 221844

Powered by Google App Engine
This is Rietveld 408576698