Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Side by Side Diff: android_webview/browser/aw_form_database_service.h

Issue 23803005: Fix threading issues in aw form database (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: minor comment update Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ANDROID_WEBVIEW_BROWSER_AW_FORM_DATABASE_SERVICE_H_ 5 #ifndef ANDROID_WEBVIEW_BROWSER_AW_FORM_DATABASE_SERVICE_H_
6 #define ANDROID_WEBVIEW_BROWSER_AW_FORM_DATABASE_SERVICE_H_ 6 #define ANDROID_WEBVIEW_BROWSER_AW_FORM_DATABASE_SERVICE_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/synchronization/waitable_event.h"
11 #include "components/autofill/core/browser/webdata/autofill_webdata_service.h" 10 #include "components/autofill/core/browser/webdata/autofill_webdata_service.h"
12 #include "components/webdata/common/web_data_service_consumer.h" 11 #include "components/webdata/common/web_data_service_consumer.h"
13 #include "components/webdata/common/web_database_service.h" 12 #include "components/webdata/common/web_database_service.h"
14 13
14 namespace base {
15 class WaitableEvent;
16 };
17
15 namespace android_webview { 18 namespace android_webview {
16 19
17 // Handles the database operations necessary to implement the autocomplete 20 // Handles the database operations necessary to implement the autocomplete
18 // functionality. This includes creating and initializing the components that 21 // functionality. This includes creating and initializing the components that
19 // handle the database backend, and providing a synchronous interface when 22 // handle the database backend, and providing a synchronous interface when
20 // needed (the chromium database components have an async. interface). 23 // needed (the chromium database components have an async. interface).
21 class AwFormDatabaseService : public WebDataServiceConsumer { 24 class AwFormDatabaseService : public WebDataServiceConsumer {
22 public: 25 public:
23 AwFormDatabaseService(const base::FilePath path); 26 AwFormDatabaseService(const base::FilePath path);
24 27
(...skipping 10 matching lines...) Expand all
35 38
36 scoped_refptr<autofill::AutofillWebDataService> 39 scoped_refptr<autofill::AutofillWebDataService>
37 get_autofill_webdata_service(); 40 get_autofill_webdata_service();
38 41
39 // WebDataServiceConsumer implementation. 42 // WebDataServiceConsumer implementation.
40 virtual void OnWebDataServiceRequestDone( 43 virtual void OnWebDataServiceRequestDone(
41 WebDataServiceBase::Handle h, 44 WebDataServiceBase::Handle h,
42 const WDTypedResult* result) OVERRIDE; 45 const WDTypedResult* result) OVERRIDE;
43 46
44 private: 47 private:
45 // Cancels the currently pending WebDataService query, if there is one. 48 struct PendingQuery {
46 void CancelPendingQuery(); 49 bool* result;
50 base::WaitableEvent* completion;
51 };
52 typedef std::map<WebDataServiceBase::Handle, PendingQuery> QueryMap;
47 53
48 void HasFormDataImpl(); 54 void ClearFormDataImpl();
55 void HasFormDataImpl(base::WaitableEvent* completion, bool* result);
49 56
50 // Stores the query handle when an async database query is executed. 57 QueryMap result_map_;
51 WebDataServiceBase::Handle pending_query_handle_;
52 bool has_form_data_;
53 base::WaitableEvent completion_;
54 58
55 scoped_refptr<autofill::AutofillWebDataService> autofill_data_; 59 scoped_refptr<autofill::AutofillWebDataService> autofill_data_;
56 scoped_refptr<WebDatabaseService> web_database_; 60 scoped_refptr<WebDatabaseService> web_database_;
57 61
58 DISALLOW_COPY_AND_ASSIGN(AwFormDatabaseService); 62 DISALLOW_COPY_AND_ASSIGN(AwFormDatabaseService);
59 }; 63 };
60 64
61 } // namespace android_webview 65 } // namespace android_webview
62 66
63 #endif // ANDROID_WEBVIEW_BROWSER_AW_FORM_DATABASE_SERVICE_H_ 67 #endif // ANDROID_WEBVIEW_BROWSER_AW_FORM_DATABASE_SERVICE_H_
OLDNEW
« no previous file with comments | « android_webview/browser/aw_browser_context.cc ('k') | android_webview/browser/aw_form_database_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698