Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: components/sync/protocol/sync.proto

Issue 2380143002: [Sync] Enable Compression from Client to Server by experiment (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/sync/BUILD.gn ('K') | « components/sync/engine_impl/commit.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/protocol/sync.proto
diff --git a/components/sync/protocol/sync.proto b/components/sync/protocol/sync.proto
index f29afb31f34cdff5feee41dc1a52bf45962e6322..a9301d36bb91edf756f1da6551ed561e4b7b6342 100644
--- a/components/sync/protocol/sync.proto
+++ b/components/sync/protocol/sync.proto
@@ -431,6 +431,13 @@ message CommitMessage {
// Set of optional per-client datatype contexts.
repeated DataTypeContext client_contexts = 5;
+
+ // This field need to be 256 bytes if set. This attempts to mitigate CRIME
+ // attacks when sync communicate from client to server with compression. So if
+ // compression is used, this need to set a 256 random ASCII bytes. If no
+ // compression, this field should not be set. The server can ignore the
+ // padding.
+ optional string padding = 6;
};
// This message communicates additional per-type information related to
« components/sync/BUILD.gn ('K') | « components/sync/engine_impl/commit.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698