Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2380133002: Show search engine promo dialog for special locale (Closed)
Patch Set: maria's comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index bb500abb1bb367cf6b7ebac674c674b1b99cf1f0..fbed1d1e5f2c7d6432363d427900760073fa1695 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -62,6 +62,7 @@ import org.chromium.chrome.browser.firstrun.FirstRunSignInProcessor;
import org.chromium.chrome.browser.firstrun.FirstRunStatus;
import org.chromium.chrome.browser.incognito.IncognitoNotificationManager;
import org.chromium.chrome.browser.infobar.DataReductionPromoInfoBar;
+import org.chromium.chrome.browser.locale.LocaleManager;
import org.chromium.chrome.browser.metrics.ActivityStopMetrics;
import org.chromium.chrome.browser.metrics.LaunchMetrics;
import org.chromium.chrome.browser.metrics.StartupMetrics;
@@ -200,6 +201,8 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
private Boolean mIsAccessibilityEnabled;
+ private LocaleManager mLocaleManager;
+
/**
* Keeps track of whether or not a specific tab was created based on the startup intent.
*/
@@ -345,6 +348,10 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
int incognitoCount = TabWindowManager.getInstance().getIncognitoTabCount();
if (incognitoCount == 0) IncognitoNotificationManager.dismissIncognitoNotification();
+ // LocaleManager can only function after the native library is loaded.
+ mLocaleManager = LocaleManager.getInstance();
+ mLocaleManager.showSearchEnginePromoIfNeeded(this);
+
super.finishNativeInitialization();
} finally {
TraceEvent.end("ChromeTabbedActivity.finishNativeInitialization");
@@ -521,6 +528,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
// This assumes that the keyboard can not be seen at the same time as the
// newtab button on the toolbar.
getCurrentTabCreator().launchNTP();
+ mLocaleManager.showSearchEnginePromoIfNeeded(ChromeTabbedActivity.this);
}
};
OnClickListener bookmarkClickHandler = new OnClickListener() {
@@ -651,6 +659,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
mIsOnFirstRun = false;
if (resultCode == RESULT_OK) {
refreshSignIn();
+ mLocaleManager.showSearchEnginePromoIfNeeded(this);
} else {
if (data != null && data.getBooleanExtra(
FirstRunActivity.RESULT_CLOSE_APP, false)) {
@@ -1023,6 +1032,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
RecordUserAction.record("MobileMenuNewTab");
RecordUserAction.record("MobileNewTabOpened");
getTabCreator(false).launchUrl(UrlConstants.NTP_URL, TabLaunchType.FROM_CHROME_UI);
+ mLocaleManager.showSearchEnginePromoIfNeeded(this);
} else if (id == R.id.new_incognito_tab_menu_id) {
if (PrefServiceBridge.getInstance().isIncognitoModeEnabled()) {
getTabModelSelector().getModel(false).commitAllTabClosures();

Powered by Google App Engine
This is Rietveld 408576698