Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp

Issue 2379823003: Move MHTML file writing out of the renderer main thread. (Closed)
Patch Set: Address reviewer comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
diff --git a/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp b/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
index 09d61918d13cea2522f5b5893fedf9f19981290f..cca842e5ccd52da9bb7b2e4f0fee3ac363c6f0c4 100644
--- a/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
+++ b/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
@@ -110,7 +110,7 @@ bool MHTMLArchive::canLoadArchive(const KURL& url) {
void MHTMLArchive::generateMHTMLHeader(const String& boundary,
const String& title,
const String& mimeType,
- SharedBuffer& outputBuffer) {
+ Vector<char>& outputBuffer) {
ASSERT(!boundary.isEmpty());
ASSERT(!mimeType.isEmpty());
@@ -149,7 +149,7 @@ void MHTMLArchive::generateMHTMLPart(const String& boundary,
const String& contentID,
EncodingPolicy encodingPolicy,
const SerializedResource& resource,
- SharedBuffer& outputBuffer) {
+ Vector<char>& outputBuffer) {
ASSERT(!boundary.isEmpty());
ASSERT(contentID.isEmpty() || contentID[0] == '<');
@@ -229,7 +229,7 @@ void MHTMLArchive::generateMHTMLPart(const String& boundary,
}
void MHTMLArchive::generateMHTMLFooter(const String& boundary,
- SharedBuffer& outputBuffer) {
+ Vector<char>& outputBuffer) {
ASSERT(!boundary.isEmpty());
CString asciiString = String("--" + boundary + "--\r\n").utf8();
outputBuffer.append(asciiString.data(), asciiString.length());
« no previous file with comments | « third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h ('k') | third_party/WebKit/Source/web/WebFrameSerializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698