Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 23798002: Cleanup: Make Platform::crypto() required. (Closed)

Created:
7 years, 3 months ago by eroman
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, abarth-chromium
Visibility:
Public.

Description

Cleanup: Make Platform::crypto() required. The feature can be turned off via a runtime flag, so not much to be gained by allowing NULL when it is on. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -26 lines) Patch
M Source/modules/crypto/SubtleCrypto.cpp View 5 chunks +7 lines, -25 lines 0 comments Download
M public/platform/Platform.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
7 years, 3 months ago (2013-08-30 00:36:01 UTC) #1
abarth-chromium
lgtm Yay. Much better.
7 years, 3 months ago (2013-08-30 07:05:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/23798002/1
7 years, 3 months ago (2013-08-30 07:06:04 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 09:21:54 UTC) #4
Message was sent while issue was closed.
Change committed as 156976

Powered by Google App Engine
This is Rietveld 408576698