chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java - Issue 2379783002: Instant App Banner logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

Issue 2379783002: Instant App Banner logic. (Closed)

Patch Set: Fixing tests. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

index d994d8264196897fcbdd884d57ac03ad1a40217a..54e9f3c2df4f6e7534f32296a8ccc33fa1386bbe 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

@@ -560,8 +560,11 @@ public class ExternalNavigationDelegateImpl implements ExternalNavigationDelegat

}

@Override

- public boolean maybeLaunchInstantApp(String url, String referrerUrl) {

- return InstantAppsHandler.getInstance().handleNavigation(getAvailableContext(), url,

- TextUtils.isEmpty(referrerUrl) ? null : Uri.parse(referrerUrl));

+ public boolean maybeLaunchInstantApp(Tab tab, String url, String referrerUrl) {

+ if (tab == null) return false;

+ return InstantAppsHandler.getInstance().handleNavigation(

+ getAvailableContext(), url,

+ TextUtils.isEmpty(referrerUrl) ? null : Uri.parse(referrerUrl),

+ tab.getWebContents());

}