Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 23794002: Store the Activity and the ApplicationContext in Tab (Closed)

Created:
7 years, 3 months ago by David Trainor- moved to gerrit
Modified:
7 years, 3 months ago
Reviewers:
Ted C, qinmin
CC:
chromium-reviews
Visibility:
Public.

Description

Store the Activity and the ApplicationContext in Tab - This refactor broke a component that required the ContentViewCore to hold an Activity Context. BUG=277135 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220420

Patch Set 1 #

Patch Set 2 : Can't pass Activiyt :( #

Patch Set 3 : Add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/TabBase.java View 1 2 4 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
David Trainor- moved to gerrit
ptal
7 years, 3 months ago (2013-08-29 23:02:21 UTC) #1
Ted C
lgtm w/ TODO
7 years, 3 months ago (2013-08-29 23:05:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/23794002/7001
7 years, 3 months ago (2013-08-29 23:08:35 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 23:10:18 UTC) #4
Message was sent while issue was closed.
Change committed as 220420

Powered by Google App Engine
This is Rietveld 408576698