Issue 23791003: Add missing includes to media players.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23791003: Add missing includes to media players. (Closed)

Created:
7 years, 3 months ago by mtomasz

Modified:
7 years, 3 months ago

Reviewers:
hirono

CC:
chromium-reviews, feature-media-reviews_chromium.org, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add missing includes to media players. Missing includes broke Files app's media players after recent change in the volume manager. NOTRY=true TEST=Check if videos and music are playing. BUG=284666 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221155

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -1 line)			Patch
M	chrome/browser/resources/file_manager/js/media/mediaplayer_scripts.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/media/video_player_scripts.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/mediaplayer.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/video_player.html	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/23791003/1

7 years, 3 months ago (2013-09-04 03:30:58 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=23643

7 years, 3 months ago (2013-09-04 03:44:16 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/23791003/1

7 years, 3 months ago (2013-09-04 03:45:35 UTC) #5

Message was sent while issue was closed.

Change committed as 221155

Expand Messages | Collapse Messages