Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

Issue 23791002: [telemetry] Add IEDriverServer to Google Storage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix a nit. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/bin/README.chromium ('k') | tools/telemetry/telemetry/page/cloud_storage.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py
diff --git a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py
index 8413f369720502ce5655bba49e0f873f9513195d..a66721ac799a5758814eb1cdc2f68b203424dc4b 100644
--- a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py
+++ b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py
@@ -12,6 +12,7 @@ from telemetry.core import possible_browser
from telemetry.core import platform
from telemetry.core import util
from telemetry.core.backends.webdriver import webdriver_browser_backend
+from telemetry.page import cloud_storage
# Try to import the selenium python lib which may be not available.
util.AddDirToPythonPath(
@@ -63,9 +64,11 @@ class PossibleDesktopIE(PossibleWebDriverBrowser):
def CreateWebDriverBackend(self):
assert webdriver
def DriverCreator():
- # TODO(chrisgao): Check in IEDriverServer.exe and specify path to it when
- # creating the webdriver instance. crbug.com/266170
- return webdriver.Ie()
+ ie_driver_exe = os.path.join(util.GetTelemetryDir(), 'bin',
+ 'IEDriverServer_%s.exe' % self._architecture)
+ cloud_storage.GetIfChanged(cloud_storage.CHROMIUM_TELEMETRY_BUCKET,
+ ie_driver_exe)
+ return webdriver.Ie(executable_path=ie_driver_exe)
return webdriver_browser_backend.WebDriverBrowserBackend(
DriverCreator, False, self.finder_options)
« no previous file with comments | « tools/telemetry/bin/README.chromium ('k') | tools/telemetry/telemetry/page/cloud_storage.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698