UserManager shutdown now also stops the profile image downloader.

UserManager shutdown now also stops the profile image downloader.

UserManager owns UserImageSyncObserver, which creates and owns a
ProfileDownloader (profile_image_downloader_). This can have some URLRequest
pending during the time Chrome shuts down, which breaks things.

This CL adds code to UserImageSyncObserver::Shutdown, which is called during
UserManager::Get()->Shutdown(), to also destroy the ProfileDownloader.

BUG=276659
TBR=nkostylev@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220834

[vabr (Chromium), 2013-08-30 17:27:47]

Hi Steven,

Please take a look.

Thanks,
Vaclav

[stevenjb, 2013-08-30 17:55:06]

lgtm

+nkostylev@chromium.org for owner

https://codereview.chromium.org/23790005/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/user_image_manager.h (right):

https://codereview.chromium.org/23790005/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/user_image_manager.h:84: // Also cancel any
profile image download in progress.
nit: cancels

[vabr (Chromium), 2013-08-30 18:12:18]

Thanks, Steven.

I added Nikita in TBR, as he is OOO, and this is for a release blocker.

Cheers,
Vaclav

[commit-bot: I haz the power, 2013-08-30 18:13:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vabr@chromium.org/23790005/8001

[commit-bot: I haz the power, 2013-08-31 02:07:58]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-02 08:00:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vabr@chromium.org/23790005/8001

[commit-bot: I haz the power, 2013-09-02 11:58:29]

Change committed as 220834

[stevenjb, 2014-01-14 17:27:03]

On 2013/09/02 11:58:29, I haz the power (commit-bot) wrote:
> Change committed as 220834

lgtm

[vabr (Chromium), 2014-01-14 17:35:19]

On 2014/01/14 17:27:03, stevenjb wrote:
> On 2013/09/02 11:58:29, I haz the power (commit-bot) wrote:
> > Change committed as 220834
> 
> lgtm

Hi Steven, I think you approved this CL already 4 months ago. :) Did you mean
https://codereview.chromium.org/138063002/ instead?

Cheers,
Vaclav